Attention is currently required from: steve-m.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30051 )
Change subject: fw: Add initial support for Sony Ericsson K200i/K220i phones
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Patchset:
PS1:
Looks good to me in general.
File src/target/firmware/board/se_k2x0/init.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30051/comment/f7d6ad19_67f50652
PS1, Line 62: compal loader
There's actually no Compal's loader in these SE phones (unlike the J100i).
Is this also relevant for the TI's boot ROM?
https://gerrit.osmocom.org/c/osmocom-bb/+/30051/comment/5f855081_09401023
PS1, Line 116: LCD driver
There is no LCD support ATM, right? Looks like the comment needs to be updated.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30051
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I711702862b1cec5a8089dac071f8a171ca026003
Gerrit-Change-Number: 30051
Gerrit-PatchSet: 1
Gerrit-Owner: steve-m <steve(a)steve-m.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: steve-m <steve(a)steve-m.de>
Gerrit-Comment-Date: Mon, 07 Nov 2022 21:31:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment