Attention is currently required from: csaba.sipos, fixeria, laforge.
pespin has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email )
Change subject: nokia_site: introduce hopping control for Nokia *Site
......................................................................
Patch Set 7:
(2 comments)
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/f3af5b7f_a6e84c99?usp=... :
PS6, Line 468: DEFUN_ATTR(cfg_bts_nokia_site_hopping_type,
This is just a Nokia specific OML extension the BTS needs. […]
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/5be16043_cfaa4e93?usp=... :
PS6, Line 470: nokia_hopping
Done
Unless that 0|1 numbering is a well know thing from nokia, I'd also favour to have proper string literal which are somehow self-descriptive as Vadim proposed.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Idb1d269d2ee80d72ede2394125e8acedf0ee8b06
Gerrit-Change-Number: 39290
Gerrit-PatchSet: 7
Gerrit-Owner: csaba.sipos
metro4@freemail.hu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: csaba.sipos
metro4@freemail.hu
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Mon, 13 Jan 2025 16:18:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: csaba.sipos
metro4@freemail.hu
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
