Attention is currently required from: laforge, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/28039
)
Change subject: Update current NM object state before signalling S_NM_STATECHG
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
I suggest adding comment(s) to the respective signal
handlers stating that the NM object state has a […]
It's already commented in
the code path dispatching the signal. I'm keeping CHG to keep it in order with
existing signals.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/28039
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib46234e3f3e446e866d27b0dfee65edf4af4d2ba
Gerrit-Change-Number: 28039
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 10 May 2022 10:16:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment