Attention is currently required from: Hoernchen, fixeria, laforge, osmith, pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email )
Change subject: build: install common/GSM/transceiver libraries for emscripten and add pkg-config files ......................................................................
Patch Set 3:
(3 comments)
File GSM/Makefile.am:
https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/defca419_5939a6ae?usp=... : PS3, Line 29: gsm_headers = \
You are now also installing headers which shouldn't be installed afaiu.
Understood. I’ll adjust that once we agree on the strategy for organizing a static library suitable for building `osmo-bts-trx` and `osmo-trx` together.
File configure.ac:
https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/a480b099_18fee570?usp=... : PS3, Line 82: AC_DISABLE_SHARED dnl don't build shared libraries (emscripten)
I changed this, see my patchset in https://gerrit.osmocom. […]
Sounds good. Once this is merged, I'll rebase my branch accordingly.
https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/3414ccee_416d580e?usp=... : PS3, Line 306: PKG_CHECK_MODULES(LIBUSB, libusb-1.0)
See "https://gerrit.osmocom. […]
Sounds good. Once this is merged, I'll rebase my branch accordingly.