Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/30569 )
Change subject: Refactor code related to DL-TBF upgrade to multislot
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/tbf_dl_fsm.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/30569/comment/a91ad8c3_63f8c669
PS3, Line 347: dl_tbf_upgrade_to_multislot
So we check if this TBF can be upgraded to multislot prior to this, but do we check if we
actually have enough resources for that? Or maybe this is not needed? Imagine a situation
of a busy PCU running close to its limit of resources. Would an attempt to allocate more
resources for a new TBF fail and result in free()ing this TBF?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/30569
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I0e4f8d7e46235a471b2124b280c81ff07b6967a4
Gerrit-Change-Number: 30569
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Dec 2022 21:21:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment