Attention is currently required from: clufn.
laforge has posted comments on this change by clufn. (
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email )
Change subject: Add required conversions for IPv6 support
......................................................................
Patch Set 2:
(2 comments)
File src/conv.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/f69c803b_e570…
:
PS2, Line 114: -define(DIAMETER_ERROR_UNKOWN_SERVING_NODE, 5423).
unrelated cosmetic change. Please make sure that your patch/diff only contains actual
functional changes related to the feature you introduce, and no unrelaed
cosmetic/whitespace changes.
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/5c293c87_d1c4…
:
PS2, Line 145: address => #{ ipv4 => Addr}};
yet another unrelated cosmetic change?
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I2426e0dcee3ca92075b845f6b21a175a3d047c08
Gerrit-Change-Number: 40255
Gerrit-PatchSet: 2
Gerrit-Owner: clufn <callumfarrbennett(a)yahoo.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: clufn <callumfarrbennett(a)yahoo.com>
Gerrit-Comment-Date: Thu, 08 May 2025 08:00:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No