Attention is currently required from: clufn.
laforge has posted comments on this change by clufn. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email )
Change subject: Add required conversions for IPv6 support ......................................................................
Patch Set 2:
(2 comments)
File src/conv.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/f69c803b_e5705... : PS2, Line 114: -define(DIAMETER_ERROR_UNKOWN_SERVING_NODE, 5423). unrelated cosmetic change. Please make sure that your patch/diff only contains actual functional changes related to the feature you introduce, and no unrelaed cosmetic/whitespace changes.
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/5c293c87_d1c42... : PS2, Line 145: address => #{ ipv4 => Addr}}; yet another unrelated cosmetic change?