Attention is currently required from: dexter, laforge, neels.
osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41642?usp=email )
Change subject: setup.py: Align cmd2 minimum version with requirements.txt ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I believe it's worth mentioning that `debian:trixie` provides `2.5. […]
Good points. I think we need to figure out which versions of cmd2 we want to support. We could do e.g. the following:
1) Use this patch as-is and just require cmd2 >= 2.6.2 for PySim. We can then remove the backwards compatibility code you mentioned in a follow-up patch. The big advantage is that users won't have ancient cmd2 versions, against which we potentially might have incompatibilities over time without realizing it. It would make sense to update the description in README.md for installing pysim to rely on pip packages instead of debian packages:
``` $ python3 -m venv .venv $ . .venv/bin/activate $ pip install -r requirements.txt ```
2) Require cmd2 >= 1.5 (as before) in both setup.py and requirements.txt, and force in contrib/jenkins.sh that cmd2 >= 2.6.2 is installed similar to https://gitea.osmocom.org/sim-card/pysim/commit/004b06eab1d89ba2b29d7de9b774.... This has the advantage that people can still use their older versions from distro packages.
We don't build pysim in the Osmocom OBS. Personally I would be fine with 1), but maybe others have different opinions. Thoughts?