Attention is currently required from: fixeria, laforge.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/41712?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified-1 by Jenkins Builder
Change subject: pyshark_gsmtap: Adjust display filter for some wireshark versions ......................................................................
pyshark_gsmtap: Adjust display filter for some wireshark versions
On my debian unstable system with wireshark 4.6.2-3, the pyshark_gsmtap APDU source misses to report any ATRs, as those are not part of what's reported with the 'gsm_sim' display filter. This is due to wireshark.git commit bcd82e2370d18e20983b378d494964d89c191cef first part of the 4.6.0 release, which splits the ATR dissection into a separate sub-dissector.
We cannot use the seemingly logical 'gsmtap.type == 4' instead, as old wireshark simply bypasses any output for the gsmtap header if the SIM sub-dissector is used.
Hence, 'gsm_sim || iso7816.atr' is something compatible with older and newer wireshark versions.
Change-Id: I53c1c8ed58a82c37cd4be4af3890af21da839e86 --- M pySim/apdu_source/pyshark_gsmtap.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/12/41712/2