Change in osmo-e1d[master]: octoi: add new counter every time a connection is accepted

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27843 ) Change subject: octoi: add new counter every time a connection is accepted ...................................................................... octoi: add new counter every time a connection is accepted This adds a new [rate] counter "e1oip:connect_accepted" that increments every time the connection is accepted for both server and client role. The rate is not really interesting, it's more the total absolute quantity that's interesting. Plotting the delta will give us spikes whenever the connection is re-established. Change-Id: I8baac768289f7e01d943f5205afa824f367a3a61 --- M src/octoi/e1oip.c M src/octoi/e1oip.h M src/octoi/octoi_clnt_fsm.c M src/octoi/octoi_srv_fsm.c 4 files changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved tnt: Looks good to me, but someone else must approve diff --git a/src/octoi/e1oip.c b/src/octoi/e1oip.c index 7f15e45..cf04c9a 100644 --- a/src/octoi/e1oip.c +++ b/src/octoi/e1oip.c @@ -50,6 +50,7 @@ [LINE_CTR_E1oIP_E1O_OVERFLOW] = { "e1oip:e1o_overflow", "Frames overflowed in IP->E1 direction"}, [LINE_CTR_E1oIP_RX_OUT_OF_ORDER] = { "e1oip:rx:pkt_out_of_order", "Packets out-of-order in IP->E1 direction"}, [LINE_CTR_E1oIP_RX_OUT_OF_WIN] = { "e1oip:rx:pkt_out_of_win", "Packets out-of-rx-window in IP->E1 direction"}, + [LINE_CTR_E1oIP_CONNECT_ACCEPT] = { "e1oip:connect_accepted", "OCTOI connections entering accepted state" }, }; static const struct rate_ctr_group_desc iline_ctrg_desc = { diff --git a/src/octoi/e1oip.h b/src/octoi/e1oip.h index 41f35cb..b643b5a 100644 --- a/src/octoi/e1oip.h +++ b/src/octoi/e1oip.h @@ -22,6 +22,7 @@ LINE_CTR_E1oIP_E1O_OVERFLOW, LINE_CTR_E1oIP_RX_OUT_OF_ORDER, LINE_CTR_E1oIP_RX_OUT_OF_WIN, + LINE_CTR_E1oIP_CONNECT_ACCEPT, }; enum e1oip_line_stat { diff --git a/src/octoi/octoi_clnt_fsm.c b/src/octoi/octoi_clnt_fsm.c index 6b1d1d3..441f904 100644 --- a/src/octoi/octoi_clnt_fsm.c +++ b/src/octoi/octoi_clnt_fsm.c @@ -118,6 +118,7 @@ /* reset RIFO/FIFO etc. */ e1oip_line_reset(st->peer->iline); + iline_ctr_add(st->peer->iline, LINE_CTR_E1oIP_CONNECT_ACCEPT, 1); st->peer->tdm_permitted = true; osmo_timer_schedule(&st->rx_alive_timer, 3, 0); diff --git a/src/octoi/octoi_srv_fsm.c b/src/octoi/octoi_srv_fsm.c index c9fa66e..53b79e7 100644 --- a/src/octoi/octoi_srv_fsm.c +++ b/src/octoi/octoi_srv_fsm.c @@ -171,6 +171,7 @@ /* reset RIFO/FIFO etc. */ e1oip_line_reset(st->peer->iline); + iline_ctr_add(st->peer->iline, LINE_CTR_E1oIP_CONNECT_ACCEPT, 1); st->peer->tdm_permitted = true; osmo_timer_schedule(&st->rx_alive_timer, 3, 0); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27843 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I8baac768289f7e01d943f5205afa824f367a3a61 Gerrit-Change-Number: 27843 Gerrit-PatchSet: 8 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged