Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41016?usp=email )
Change subject: Remove duplicate 3GPP-AAA-Server-Name definition and break 3-way circular dependency ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
unresolved this comment.
I think that's something we should be doing in general for all files, ie. separating basic types from grouped AVP/messages, eg: ts29_273_types.dia ts29_273_grouped.dia
But I consider this to be not strictly necessary for the already convoluted fixes to get it working for now. I don't want to spend more time than the strictly encessary one to have indirect_inherit working so we can test the feature from upstream easily.