Attention is currently required from: pespin, fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/29537 )
Change subject: power_control: add CTRL command for sending default params
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/osmo-bsc/bsc_ctrl_commands.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/29537/comment/72ee694d_08a6abca
PS2, Line 315: cmd->reply = "Default power control parameters have been
sent";
I would really simply write "OK" here, this
looks way to verbose imho.
agreeing with pespin
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/29537
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib370bd97ee2d9f72f8bec553550b1792d1345387
Gerrit-Change-Number: 29537
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Sep 2022 11:27:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment