Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26955 )
Change subject: ranap_common_ran: add decoder for RAN/RNC originated messages ......................................................................
Patch Set 5:
(6 comments)
Patchset:
PS5: Mostly cosmetic notes, not a merge blocker.
File include/osmocom/ranap/ranap_common.h:
https://gerrit.osmocom.org/c/osmo-iuh/+/26955/comment/27b84377_1802f520 PS5, Line 599: funktions Tippfehler: functions
File src/ranap_common_ran.c:
https://gerrit.osmocom.org/c/osmo-iuh/+/26955/comment/7030b23e_7396dc5d PS5, Line 90: unsuccessfulOutcome successfulOutcome? I think it's not critical, given that 'procedureCode' is present in all union members at the same position. But still may be confusing.
https://gerrit.osmocom.org/c/osmo-iuh/+/26955/comment/da00cf9b_8956d22e PS5, Line 102: unsuccessfulOutcome outcome? I think it's not critical, given that 'procedureCode' is present in all union members at the same position. But still may be confusing.
https://gerrit.osmocom.org/c/osmo-iuh/+/26955/comment/2ef5a507_79f42b5f PS5, Line 124: unsuccessful copy-paste: successful
https://gerrit.osmocom.org/c/osmo-iuh/+/26955/comment/0b68a617_a523c973 PS5, Line 132: unsuccessful Neither unsuccessful not successful, so this word should be removed.