Attention is currently required from: daniel, fixeria, jolly, laforge.
Hello Jenkins Builder, daniel, fixeria, jolly, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-netif/+/41666?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed: Verified+1 by Jenkins Builder
Change subject: cosmetic: stream_srv: srv_link: Document no need for OSMO_SOCK_F_NONBLOCK ......................................................................
cosmetic: stream_srv: srv_link: Document no need for OSMO_SOCK_F_NONBLOCK
osmo_fd_register() currently takes care of setting the socket as non-blocking, before any blocking call is performed. Document it.
If we ever switch from osmo_fd to io_uring to process the accept() op then we won't need to set the socket as nonblocking anyway, since io_uring expects to work with blocking sockets.
Change-Id: I98a6ef55a0a7289b9eeb7e8062e9afa4d87f51eb --- M src/stream_srv.c 1 file changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/66/41666/5