Attention is currently required from: daniel.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31071 )
Change subject: netdev: Fix compilation building with --disable-libmnl
......................................................................
Patch Set 2:
(1 comment)
File src/core/netdev.c:
https://gerrit.osmocom.org/c/libosmocore/+/31071/comment/c5d72226_a61b181c
PS1, Line 845:
But you're only doing the netns enter/exit to
(not) call the mnl function? […]
Now yes, but I'd need to do that anyway for
instance if an ioctl() based implementation is added (I even already had an ioctl()
function in a previous patch adding osmo_netdev).
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31071
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I62bdea075afb9e0cc2bbcec6dd3a930e8f7bbc40
Gerrit-Change-Number: 31071
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Jan 2023 16:20:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment