Attention is currently required from: pespin.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31303 )
Change subject: Includes: Add gprs/rlc related enums
......................................................................
Patch Set 7:
(2 comments)
File include/osmocom/gprs/gprs_bssgp.h:
https://gerrit.osmocom.org/c/libosmocore/+/31303/comment/6fe930c1_671395db
PS4, Line 205: /* BSSGP procedure timing - timers and related counters (TS 101 343 v8.12.0
section 12.1)
AFAIC first ETSI managed the releases, and afterwards
they were transferred to 3GPP. […]
Done
File include/osmocom/gprs/gprs_rlc.h:
https://gerrit.osmocom.org/c/libosmocore/+/31303/comment/973eab19_821a1f1a
PS1, Line 47: enum gprs_rlc_par {
Please check which similar fields/enums are used when
encoding the msg transmitted into the wire, an […]
I already had looked at files in
`libosmo-abis/include/osmocom/abis`, but there isn't much to go on: Hardly any
constants, and I didn't feel like it fit in anywhere.
Looking for 'OML' or 'oml' in `libosmo-abis/include` also doesn't give
anything worthwile (same with `12` or `21).
The only defines around usage of that buffer come from
`libosmocore/osmocom/gsm/protocol/gsm_12_21.h` I think. At least currently that header
seems to be pretty clear of anything above the Abis layer, though.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31303
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1ec2e52ad7fa625c08fe9df04d4a4f5323bf609c
Gerrit-Change-Number: 31303
Gerrit-PatchSet: 7
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Feb 2023 14:05:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment