26 Sep
2024
26 Sep
'24
4:03 p.m.
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38297?usp=email )
Change subject: s1gw_metrics: more precise type hints ......................................................................
Patch Set 2:
(1 comment)
File src/s1gw_metrics.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38297/comment/0fe924db_bc816... : PS2, Line 85: -type counter() :: [ctr | _]. can you explain this to me? it kind of matches tokens starting with ctr?
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38297?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I36eaa5e04037e165e43eb960c541f967c394a2ea
Gerrit-Change-Number: 38297
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Thu, 26 Sep 2024 14:03:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No