Attention is currently required from: laforge, neels, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/42120?usp=email )
Change subject: cp_peer: Implement local originated heartbeat procedure ......................................................................
Patch Set 1:
(1 comment)
File src/libosmo-pfcp/pfcp_cp_peer.c:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/42120/comment/df323e70_1ce96a5a?... : PS1, Line 112: unsigned int tval_rx_heartbeat_s = : osmo_tdef_get(cp_peer->ep->cfg.tdefs, OSMO_PFCP_TIMER_HEARTBEAT_RESP, OSMO_TDEF_S, -1); : o
No, because the Tx of Heartbeat Req is decoupled from Rx of Heartbeat Response. […]
I understand that the user can configure the HB interval and response timeout separately - this is fine. What I don't understand is why you're re-starting the response timer here.
Let's say we have the following configuration:
* `tval_tx_heartbeat_s` (HB interval) = 10s * `tval_rx_heartbeat_s` (HB response timeout) = 3s
Scenario:
* [0.0s] Tx HEARTBEAT Req (initial) * re-schedule `heartbeat_tx_timer` (+10s) * re-schedule `heartbeat_rx_timer` (+3s) * [+0.5s] Rx HEARTBEAT Rsp * re-schedule `heartbeat_rx_timer` (+3s) * [+3.5s] `heartbeat_rx_timer` expires * `PFCP_CP_PEER_EV_HEARTBEAT_TIMEOUT`
Am I missing something?