6 Nov
2024
6 Nov
'24
7:08 p.m.
Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584?usp=email )
Change subject: library/gsup: rework f_gen_{tr,ts}_ss_ies() and SS templates ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I find this commit really difficult to review, with different stuff in it. […]
I acknowledge that it's not easy to review this patch, but it's all related changes and splitting it further would require some more work and another round of testing...
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia611ffa3845d48c5553c70f10981aa029d00d873
Gerrit-Change-Number: 38584
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Wed, 06 Nov 2024 18:08:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de