Attention is currently required from: laforge, lynxis lazus, pespin.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email )
Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits ......................................................................
Patch Set 2:
(1 comment)
File pcu/PCU_Tests_SNS.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/af3277b0_ba30b... : PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0
I'm sorry but I don't think it's good to start using parameters in testcase with no real good reason [...]
It's good to know that one can pass arguments to testcases; ETSI ES 201 873-1 V4.16.1 confirms this is possible in section 26.1. But I agree with @pespin@sysmocom.de here. It needs to be researched further how the resulting junit xml file would look like. And in this specific case, you're not calling `TC_sns_del` with different parameters in the `control` section, so unless you're planning to do so I don't see a reason for having those params.