Attention is currently required from: lynxis lazus, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34654?usp=email )
Change subject: Initial work to have proper app compilation and escript generation
......................................................................
Patch Set 2:
(2 comments)
File Makefile:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34654/comment/31d8501b_09ef…
PS2, Line 14: rm -rf _build/
"No newline at end of right file."
(shouldn't the text editor add it automatically?)
File src/osmo_epdg.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34654/comment/caaaa1d0_2690…
PS2, Line 7: timer:sleep(infinity).
same here, missing newline (git is complaining)
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34654?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I83b9117a1d611a1b992ddf052450509f9bd16964
Gerrit-Change-Number: 34654
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 05 Oct 2023 14:25:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment