Attention is currently required from: pespin, dexter.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/30864 )
Change subject: bts: use GSM_TDMA_FN_ macros and uint32_t in bts_rfn_to_fn
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
I assume you verified this variable never can hold a
negative value (being named "relative").
This can be easily checked by
grepping for bts_rfn_to_fn. In nearly all cases the callers pass rip->rfn to this
function, which is unsigned. Relative in this context means "relative to the PDCH
multiframe period", AFAIU.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/30864
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iedd493bb30dd1c342dec031883060c545432e740
Gerrit-Change-Number: 30864
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 05 Jan 2023 17:49:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment