Attention is currently required from: laforge, pespin, dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33634 )
Change subject: S1AP_Templates: fix tr_S1AP_SetupResp
......................................................................
Patch Set 1:
(1 comment)
File library/s1ap/S1AP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33634/comment/8f0aba9f_2e423...
PS1, Line 116: *, {
I don't know if the protocolIEs field ends up being a "set of" or "record of" in TTCN3. […]
Like in the preceding patch, there is only one *optional* `MME Name` IE. Using `?` would mean we expect it to be always present. I like the idea of `superset`, but I am afraid those PDUs are automatically generated from ASN.1 by TITAN?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33634
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I07513743142f519481530801d4e1185d55f6ea4b
Gerrit-Change-Number: 33634
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Sun, 09 Jul 2023 11:37:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment
