Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27708 )
Change subject: Proper exit if bsc_nat_fsm fails to start ......................................................................
Patch Set 3:
(2 comments)
File src/osmo-bsc-nat/bsc_nat_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27708/comment/e6e110a5_37196e57 PS2, Line 479: osmo_fsm_inst_dispatch(bsc_nat->fi, BSC_NAT_FSM_EV_START, NULL);
int bsc_nat_fsm_start(struct bsc_nat *bsc_nat) { […]
Done
File src/osmo-bsc-nat/main.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27708/comment/40bc92b0_0b27eea6 PS2, Line 202: if (!bsc_nat_fsm_is_started(g_bsc_nat)) {
This looks weird. Why not: […]
Done