arehbein has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/32810 )
Change subject: stream: Fix endless loop on server on client disconnect ......................................................................
stream: Fix endless loop on server on client disconnect
Not sure why, but select() keeps reporting read events it seems, even though the client doesn't send any packets anymore. Without this line, the server gets stuck in an endless read loop with zero bytes read because of that.
Change-Id: I012ddf14ae17642a52d34026d85ab6958cf488a1 --- M src/stream.c 1 file changed, 15 insertions(+), 0 deletions(-)
Objections: Jenkins Builder: Fails
diff --git a/src/stream.c b/src/stream.c index 98a4be9..421c951 100644 --- a/src/stream.c +++ b/src/stream.c @@ -1409,6 +1409,7 @@ if (conn->flags & OSMO_STREAM_SRV_F_FLUSH_DESTROY) { LOGP(DLINP, LOGL_DEBUG, "Connection is being flushed and closed; ignoring received message\n"); msgb_free(msg); + osmo_stream_srv_destroy(conn); return; }