Attention is currently required from: fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/33092 )
Change subject: libosmogsm: Factor out the C2 derivation function
......................................................................
Patch Set 4:
(2 comments)
File src/gsm/auth_core.c:
https://gerrit.osmocom.org/c/libosmocore/+/33092/comment/3d077674_ccf3807f
PS4, Line 364: param[in]
missing param name (syntax error), please add
`sres_deriv_func`
Done
https://gerrit.osmocom.org/c/libosmocore/+/33092/comment/8e92171c_0b1ab840
PS4, Line 372: memcpy(xres, res, res_len);
maybe do `OSMO_ASSERT(res_len <= sizeof(xres))`
before calling `memcpy()`? […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/33092
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0e7cd55f5578f891cb6cc1b0442920ba5beddae4
Gerrit-Change-Number: 33092
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Jun 2023 13:33:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment