Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34532?usp=email )
Change subject: rlcmac: Fix compilation error 'rlcmac_prim may be used uninitialized' ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-gprs/+/34532/comment/f206c296_be149194 PS1, Line 7: error Is it really an error? Or a warning that becomes an error when building with `--disable-werror`?
File src/rlcmac/tbf_ul_ass_fsm.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/34532/comment/1378440f_5568a280 PS1, Line 121: default For the record: I intentionally did not add the `default` branch, because I expected that a warning would be thrown whenever a new enum item is added to `enum gprs_rlcmac_tbf_ul_ass_type`. I think I also did this in other projects. But looks like the compiler is over defensive here :/