Attention is currently required from: Timur Davydov, laforge, neels, pespin.
fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email )
Change subject: Add Emscripten build support and JS callback logging backend ......................................................................
Patch Set 7:
(4 comments)
File src/core/osmo_io_internal.h:
https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/420d4965_3d83441b?u... : PS5, Line 7: HAVE_LIBSCTP
Thanks for catching this! […]
Done
File src/vty/logging_vty.c:
https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/96a31399_f4270c3f?u... : PS5, Line 1130:
Thanks, fixed
Done
https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/d5804da1_0b1a4509?u... : PS5, Line 1361: install_lib_element(CONFIG_NODE, &cfg_log_web_cmd); : install_lib_element(CONFIG_NODE, &cfg_no_log_web_cmd);
Thanks — added conditional compilation `#if defined(__EMSCRIPTEN__)`
Done
File src/vty/telnet_interface_dummy.c:
https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/4e05164d_0c01dcff?u... : PS5, Line 18: #include <sys/socket.h> : #include <netinet/in.h> : #include <errno.h> : #include <stdlib.h> : #include <stdio.h> : #include <string.h> : #i
Thanks for pointing that out! […]
Done