Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email )
Change subject: tests: Test gsmtap logging if write queue fills up ......................................................................
Patch Set 1:
(3 comments)
File tests/logging/logging_test_gsmtap.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12292): https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/e654eaaf_92b1cc35 PS1, Line 57: for (int i = 0; i < 200; i++) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12292): https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/7f9350c7_afc521ec PS1, Line 58: DEBUGP(DLGLOBAL, "Repeating message (i = %i)\n", i); Use %d instead of %i
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12292): https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/f3c2cda0_9a241246 PS1, Line 61: for (int i = 0; i < 200; i++) { braces {} are not necessary for single statement blocks