Attention is currently required from: pespin, daniel, dexter.
lynxis lazus has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106 )
Change subject: Add hnbgw tests
......................................................................
Patch Set 5: Code-Review+1
(5 comments)
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/a2380a80_4065…
PS5, Line 144: mgw_rtp_ip := "1.1.1.1",
could use a private ip range
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/a363ba27_9ca7…
PS5, Line 150: mgw_rtp_ip := "2.2.2.2",
could use a private ip range
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/3d0a1d5e_f144…
PS5, Line 156: hnb_rtp_ip := "1.1.1.2",
could use a private ip range
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/23a8b76d_bddd…
PS5, Line 158: cn_rtp_ip := "2.2.2.1",
could use a private ip range
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/627a1afb_0582…
PS5, Line 622: f_sleep(10.0);
10 seconds are quite long. why do we need a sleep here?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0a2fb795aec83337eda8d9972e6ff264ead61076
Gerrit-Change-Number: 27106
Gerrit-PatchSet: 5
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Feb 2022 10:22:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment