Attention is currently required from: laforge, dexter.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/33704
)
Change subject: cdma_ruim: Fix unit tests and actually enable them
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1:
Thanks. I didn't pay enough attention to unit tests and fscked up :(
File pySim/cdma_ruim.py:
https://gerrit.osmocom.org/c/pysim/+/33704/comment/5ebeaa00_2e14f3fc
PS1, Line 136: HexAdapter
Not sure if we want hex here, I would just change `'0000'` to `b'0000'`
above.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/33704
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Icdf4621eb68d05a4948ae9efeb81a007d48e1bb7
Gerrit-Change-Number: 33704
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Jul 2023 19:11:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment