laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36902?usp=email )
Change subject: osmo-smdpp.py: Resolve possible variable use before assignment ......................................................................
osmo-smdpp.py: Resolve possible variable use before assignment
osmo-smdpp.py:374:72: E0601: Using variable 'iccid_str' before assignment (used-before-assignment)
Let's raise an exception in the erroneous case.
Change-Id: I01b308226e12f91699b1b5c6bb06f853be47e185 --- M osmo-smdpp.py 1 file changed, 16 insertions(+), 0 deletions(-)
Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved
diff --git a/osmo-smdpp.py b/osmo-smdpp.py index 1f4311d..3dc6131 100755 --- a/osmo-smdpp.py +++ b/osmo-smdpp.py @@ -368,6 +368,9 @@ pes = saip.ProfileElementSequence.from_der(f.read()) iccid_str = b2h(pes.get_pe_for_type('header').decoded['iccid'])
+ # make pylint happy: E0601: Using variable 'iccid_str' before assignment (used-before-assignment) + assert iccid_str + # FIXME: we actually want to perform the profile binding herr, and read the profile metadat from the profile
# Put together profileMetadata + _bin