Attention is currently required from: neels.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34985?usp=email )
Change subject: LAPD: Add support for RTS based polling and T200 ......................................................................
Patch Set 8:
(4 comments)
File include/osmocom/isdn/lapd_core.h:
https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/215d440d_f2511945 PS8, Line 88: #define LAPD_F_RTS 0x0001
(an enum would be nicer IMHO)
There is another flag in a later patch. https://gerrit.osmocom.org/c/libosmocore/+/35015
File src/isdn/lapd_core.c:
https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/437e7a58_4f75489a PS8, Line 220: Function to
(just drop the words "Function to", rationale: it is obvious that it is a function)
Done
https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/4aeccd7b_30b7fa62 PS8, Line 400: \ref
'\ref' is not valid doxygen here, see https://osmocom. […]
Done
https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/033fbb3f_b994b69e PS8, Line 1785: Function call when a LAPD frame is ready to sent.
this is hard to understand, could you make this an "imperative form" description of what the functio […]
Done