Attention is currently required from: neels.

View Change

4 comments:

• File include/osmocom/isdn/lapd_core.h:

  • Patch Set #8, Line 88: #define LAPD_F_RTS 0x0001

    (an enum would be nicer IMHO)

    There is another flag in a later patch. https://gerrit.osmocom.org/c/libosmocore/+/35015

• File src/isdn/lapd_core.c:

  • Patch Set #8, Line 220: Function to

    (just drop the words "Function to", rationale: it is obvious that it is a function)

    Done

  • Patch Set #8, Line 400: \ref

    '\ref' is not valid doxygen here, see https://osmocom. […]

    Done

  • Patch Set #8, Line 1785: Function call when a LAPD frame is ready to sent.

    this is hard to understand, could you make this an "imperative form" description of what the functio […]

    Done

To view, visit change 34985. To unsubscribe, or for help writing mail filters, visit settings.