23 Apr
2022
23 Apr
'22
2:57 p.m.
Attention is currently required from: pespin, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27879 )
Change subject: rsl_rx_ccch_load: add explicit cast -1 to unsigned ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
Why not use UINT16_MAX instead?
was suggested by fixeria in the first comment, see above.
I would go for UINT16_MAX or even the more readable 0xffff
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27879
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I02ad80e5d10f1a47cdf712f7f7c576a2e20fe607
Gerrit-Change-Number: 27879
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Sat, 23 Apr 2022 12:57:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: daniel dwillmann@sysmocom.de
Gerrit-MessageType: comment