Attention is currently required from: pespin, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27392 )
Change subject: mgcp_codec: fix oa/bwe comparison in mgcp_codec_pt_translate() ......................................................................
Patch Set 4:
(1 comment)
File src/libosmo-mgcp/mgcp_codec.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/27392/comment/f758ae49_66c732aa PS1, Line 369: static bool codecs_same(struct mgcp_rtp_codec *codec_a, struct mgcp_rtp_codec *codec_b, bool match_pload_fmt)
Format conversion *is* transcoding :D
Yes, format conversion is transcoding in a "scientific" definition of the word. But maybe let's call one translating (format conversion) and reserve transcoding for the case commonly known as transcoding.
So I propose: * conversion as a general term for any kind * transcoding for something where we actually go through the audio codec * translation for some other mangling of payload format that doesn't involve an audio codec