14 Mar
2023
14 Mar
'23
2:08 a.m.
Attention is currently required from: osmith, neels, fixeria, msuraev.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31513 )
Change subject: GSMTAP: allow configuring src IP for log messages ......................................................................
Patch Set 13:
(1 comment)
File src/core/logging_gsmtap.c:
https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/78af4744_d4da2d91 PS12, Line 186: target->tgt_gsmtap.src_addr = talloc_strdup(target, src);
Exactly the same reasoning can be applied to hostname and ident - nothing is changed in this regard […]
Yes, the actionable suggestion is that you verify everything is fine since your are submitting this code.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31513
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9000269ce5b3dce1e757271b7c42e77b68d38f25
Gerrit-Change-Number: 31513
Gerrit-PatchSet: 13
Gerrit-Owner: msuraev msuraev@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: neels nhofmeyr@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: msuraev msuraev@sysmocom.de
Gerrit-Comment-Date: Mon, 13 Mar 2023 15:08:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Comment-In-Reply-To: msuraev msuraev@sysmocom.de
Gerrit-MessageType: comment