Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-cbc/+/28732 )
Change subject: Support CBSP/TCP and SBc-AP/SCTP client mode
......................................................................
Patch Set 5:
(2 comments)
File src/cbc_vty.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28732/comment/9a5bb7c7_6d498d60
PS3, Line 596: DEFUN
I would suggest using DEFUN_ATTR with
CMD_ATTR_NODE_EXIT here and in other commands to inform the us […]
Done
File src/cbsp_link.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28732/comment/90283a33_c6ee2e8c
PS3, Line 286: CBC_PEER_LINK_MODE_CLIENT
Because the server socket is still alive, so if the
other end is configured as client while we confi […]
Still cannot wrap my head
around this (e.g. why would the server socket be alive in client mode), perhaps because I
am not familiar with libosmo-netif API. Marking thread as resolved, as you definitely know
this API better.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-cbc/+/28732
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I3ec54b615b41b56f7a9c64298e3fcaac37f4b60e
Gerrit-Change-Number: 28732
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Jul 2022 14:57:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment