Attention is currently required from: laforge.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37010?usp=email )
Change subject: esim.saip: Add ProfileElementSequence.remove_naas_of_type ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File pySim/esim/saip/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/37010/comment/7826be67_db733953 PS3, Line 562: def remove_naas_of_type(self, naa: Naa) -> None: maybe it would be useful if this function printed which instances of NAAs it removed?
https://gerrit.osmocom.org/c/pysim/+/37010/comment/d4e9f6cd_497a73b9 PS3, Line 573: if template in hdr.decoded['eUICC-Mandatory-GFSTEList']: : hdr.decoded['eUICC-Mandatory-GFSTEList'] = [x for x in hdr.decoded['eUICC-Mandatory-GFSTEList'] if not template.prefix_match(x)] just to be sure: it cannot be that `template.prefix_match() is True` for any element of `hdr.decoded['eUICC-Mandatory-GFSTEList']`, but at the same time `template not in hdr.decoded['eUICC-Mandatory-GFSTEList']`, right?