Attention is currently required from: laforge.

Patch set 3:Code-Review +1

View Change

2 comments:

• File pySim/esim/saip/__init__.py:

  • Patch Set #3, Line 562: def remove_naas_of_type(self, naa: Naa) -> None:

    maybe it would be useful if this function printed which instances of NAAs it removed?

  • Patch Set #3, Line 573:

    if template in hdr.decoded['eUICC-Mandatory-GFSTEList']:
                    hdr.decoded['eUICC-Mandatory-GFSTEList'] = [x for x in hdr.decoded['eUICC-Mandatory-GFSTEList'] if not template.prefix_match(x)]
    

    just to be sure: it cannot be that `template.prefix_match() is True` for any element of `hdr.decoded['eUICC-Mandatory-GFSTEList']`, but at the same time `template not in hdr.decoded['eUICC-Mandatory-GFSTEList']`, right?

To view, visit change 37010. To unsubscribe, or for help writing mail filters, visit settings.