Attention is currently required from: pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/31756 )
Change subject: rlcmac: Log sched of PktCtrlAck requested by UL ASS poll
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/rlcmac/sched.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31756/comment/1fc5e61a_8bd11cb6
PS2, Line 207: (ts=%u,fn=%u,usf=%u)
this function alone seems to be using the same format string for printing at least four
times now. Time for a proper LOGP macro?
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/31756
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I81ac177d7abdcd49d2b231ae059ec859b433dd03
Gerrit-Change-Number: 31756
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Mar 2023 09:44:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment