Attention is currently required from: lynxis lazus.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40688?usp=email )
Change subject: routing area: introduce ran_type on the RA ......................................................................
Patch Set 2:
(6 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/d126487f_2539ae64?usp... : PS2, Line 9: unique uniquely
File include/osmocom/sgsn/gprs_routing_area.h:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/1dbf809b_efb97065?usp... : PS2, Line 35: 2x PCU serves you mean "more than one PCU" here?
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/0bdd8b3f_9d9e66d0?usp... : PS2, Line 38: individual individually
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/5f219d2a_d911cd33?usp... : PS2, Line 39: has have
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/9ee676e4_1745282c?usp... : PS2, Line 47: which are alive maybe call it `alive_cells` or `cells_alive` then?
File src/sgsn/gprs_routing_area.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/ce3b8e2d_c492ea83?usp... : PS2, Line 201: valid for GERAN If some API is GERAN specific, maybe function names should reflect that? Otherwise you don't know without looking at the function definition...