10 Aug
2022
10 Aug
'22
4:03 p.m.
Attention is currently required from: msuraev, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 )
Change subject: Make esme struct shared ......................................................................
Patch Set 18:
(1 comment)
File src/libsmpputil/smpp_smsc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/6e66b03b_4219ac89 PS16, Line 878: {
It's allocated with talloc_zero() already.
I don't see it being allocated in the library, so the library doesn't know about that. I see you are trying to move stuff into a library but not really respecting implementation boundaries correctly between both.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70
Gerrit-Change-Number: 28846
Gerrit-PatchSet: 18
Gerrit-Owner: msuraev msuraev@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: msuraev msuraev@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Wed, 10 Aug 2022 14:03:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Comment-In-Reply-To: msuraev msuraev@sysmocom.de
Comment-In-Reply-To: dexter pmaier@sysmocom.de
Gerrit-MessageType: comment