Change in libosmo-gprs[master]: llc: implement LLC PDU codec based on code from osmo-sgsn.git

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 ) Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git ...................................................................... Patch Set 1: (3 comments) File include/osmocom/gprs/llc/llc.h: Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-gprs-lint-39): https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/463ef40d_f375ef55 PS1, Line 135: #define OSMO_GPRS_LLC_PDU_F_ACK_REQ (1 << 2) /* 6.3.5.2 Acknowledgement request bit (A) */ 'Acknowledgement' may be misspelled - perhaps 'Acknowledgment'? File src/llc/llc_pdu.c: Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-gprs-lint-39): https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/3cb32e07_fd1188e4 PS1, Line 277: #define check_len(len, text) \ Macros with flow control statements should be avoided File tests/llc_pdu_codec/pdu_codec_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-gprs-lint-39): https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/d82258a0_8c32cbc7 PS1, Line 31: static const char *testData[] = { static const char * array should probably be static const char * const -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I61d7e2e6d0a8f2cdfc2113e637e447dc428cc70d Gerrit-Change-Number: 29402 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Sun, 18 Sep 2022 13:21:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment