Attention is currently required from: pespin, msuraev.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/28996 )
Change subject: Diversify osmo_sockaddr_str_*() error codes
......................................................................
Patch Set 5: Code-Review-2
(2 comments)
Patchset:
PS5:
at second thought, I fully agere with Pau here.
File src/sockaddr_str.c:
https://gerrit.osmocom.org/c/libosmocore/+/28996/comment/6ade53c2_eb89dad0
PS5, Line 241: ENOMEM
ENOMEM is for memory allocation failures. We don't allocate memory here. this is
wrong.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/28996
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic1be25a076776de5b417cb5ac66f954ac5680e10
Gerrit-Change-Number: 28996
Gerrit-PatchSet: 5
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 12 Aug 2022 10:57:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment