Attention is currently required from: pespin, dexter.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/32932 )
Change subject: ASCI: Add message definition and encoding according to 3GPP TS 48.008
......................................................................
Patch Set 17:
(2 comments)
File include/osmocom/gsm/gsm0808.h:
https://gerrit.osmocom.org/c/libosmocore/+/32932/comment/e9e15ef4_d1d905cb
PS13, Line 22: #include "config.h"
You are still including config.h in a public header,
this is wrong.
Done
File include/osmocom/gsm/gsm0808.h:
https://gerrit.osmocom.org/c/libosmocore/+/32932/comment/3f7b0551_546126b2
PS12, Line 22: #ifdef HAVE_SYS_SOCKET_H
Done
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32932
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib94c64136c31ce4af67c314a8550d93946cc844f
Gerrit-Change-Number: 32932
Gerrit-PatchSet: 17
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 09 Jun 2023 14:08:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment