Attention is currently required from: fixeria.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email )
Change subject: soft_uart: add unit tests for the receiver and transmitter ......................................................................
Patch Set 5:
(9 comments)
File tests/soft_uart/soft_uart_test.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/487beff6_8cbb3172 PS5, Line 111: "F" /* flush! (for sanity) */ ); space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/c3c6517d_d33f1100 PS5, Line 124: "0 11110010 1F" /* 'O', flush! */ ); space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/bb5334e9_4e17ac83 PS5, Line 131: "F" /* flush! */ ); space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/b4b8e364_07134261 PS5, Line 144: "0 11110010 1F1F" /* 'O', flush! */ ); space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/75a8d5ad_52f2d552 PS5, Line 152: "F" /* flush! (for sanity) */ ); space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/42821013_08f5e90a PS5, Line 163: "F" /* flush! (for sanity) */ ); space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/42245eaf_a1b1f4e3 PS5, Line 175: "F" /* flush! */ ); space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/1fbd1430_4194d670 PS5, Line 185: "F" /* flush! (for sanity) */ ); space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12503): https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/fcfe03d7_54d13918 PS5, Line 197: "F" /* flush! */ ); space prohibited before that close parenthesis ')'