Attention is currently required from: pespin.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31972 )
Change subject: gsm_bts_check_ny1: Prevent possible division by zero ......................................................................
Patch Set 3:
(2 comments)
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31972/comment/41a99530_49007b7a PS1, Line 1734: if (!(T3105 * ny1 > GSM_T3124_MAX + GSM_NY1_REQ_DELTA)) {
if Ny1 should always be higher than 0 (GSM_T3124_MAX + GSM_NY1_REQ_DELTA), then T3015 cannot be 0 he […]
Done
File src/osmo-bsc/net_init.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31972/comment/f7a23278_4a39df5d PS2, Line 39: { .T = 3105, .default_val = GSM_T3105_DEFAULT, .min_val = 1,
Please better keep it at one line per timer. If at all, move the desc to its own line only.
Done