Attention is currently required from: neels.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/32290
)
Change subject: mgcp_network: do not deliver RTP packets with unpatched PT
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-mgw/+/32290/comment/11fa5b13_7187e1f3
PS3, Line 9: call agent
by call agent, do you mean like BSC and MSC? So far I
see call agent as meaning a PBX like freeswitc […]
As far as I understand a call
agent is any entity that controls an MGW, it can be a BSC, MSC or a PBX.
File src/libosmo-mgcp/mgcp_network.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/32290/comment/eb90af28_86187357
PS3, Line 1168: DEBUG
I guess when we drop packets that would be LOGL_ERROR;
only problem is with spamming 20 LOGL_ERROR p […]
I think in this case LOGL_NOTICE
it is not a too big problem. mgcp_patch_pt() only fails on short RTP packets or if the
codec decision is not made properly.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/32290
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I013a24c1e0f853557257368cfab9192d4611aafa
Gerrit-Change-Number: 32290
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 26 Apr 2023 15:20:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment