Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/pysim/+/37690?usp=email )
Change subject: recognize ADF.PKCS15, allow selecting it
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File pySim/pkcs15.py:
https://gerrit.osmocom.org/c/pysim/+/37690/comment/dca71239_960bb2ce?usp=em… :
PS1, Line 32: files = [
might be worth adding a TODO / FIXME comment about this needing code to discover the files
at runtime. I think we already have similar comments in other locations where this
hapepns, like EF.ICON in DF.GRAPHICS or other instances?
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/37690?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7ea6d91805868645ae1c1a4a2c5870f7d041f74b
Gerrit-Change-Number: 37690
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Aug 2024 17:46:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes