[M] Change in osmo-ttcn3-hacks[master]: BTS_Test_ASCI: Add UPLINK FREE / UPLINK BUSY test

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33817 ) Change subject: BTS_Test_ASCI: Add UPLINK FREE / UPLINK BUSY test ...................................................................... Patch Set 3: (1 comment) File bts/BTS_Tests_ASCI.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33817/comment/ed116d0b_efb5… PS3, Line 158: RSL.send(ts_RSL_UNITDATA_REQ(g_chan_nr, ts_RslLinkID_DCCH(0), uplink_free)); : for (var integer i := 0; i < 20; i := i + 1) { : f_l1_exp_lapdm(tr_LAPDm_Bter_UI(uplink_free)); : log("Received UPLINK FREE."); : } : : /* Send one UPLINK BUSY message and expect it to be received. */ : log("Send UPLINK BUSY."); : RSL.send(ts_RSL_UNITDATA_REQ(g_chan_nr, ts_RslLinkID_DCCH(0), uplink_busy)); : f_l1_exp_lapdm(tr_LAPDm_UI(0, cr_MT_CMD, uplink_busy)); again here I smell the potential for race conditions. Things don't happen synchronously and there are many queues involved. So you cannot reliably guarantee there's no old uplink_free still receiveda this point here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2f70adb4a6f71eb8972feccf9dda0f77e7a942b9 Gerrit-Change-Number: 33817 Gerrit-PatchSet: 3 Gerrit-Owner: jolly &lt;andreas(a)eversberg.eu&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: jolly &lt;andreas(a)eversberg.eu&gt; Gerrit-Comment-Date: Wed, 19 Jul 2023 08:11:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment